[ 
https://issues.apache.org/jira/browse/HBASE-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133489#comment-13133489
 ] 

Ted Yu commented on HBASE-4388:
-------------------------------

bq. MetaMigrationRemovingHTD is deprecated already. Its going away before we 
release 0.94
I think the assumption in the above statement is that users (of 0.20.6 and 
0.89) would upgrade through 0.92 before upgrading to 0.94 (when 0.94 is 
released).
Not carrying the burden of migration logic is good for development. On the 
other hand, it is not convenient for users.
I am fine with the above assumption. We just need to explicitly state it 
somewhere.

Minor comment:
{code}
        this.htds.add(htd);
        this.services.getMasterFileSystem().createTableDescriptor(htd);
{code}
I think the order of the above two statements should be reverted because the 
second call may throw IOException.
                
> Second start after migration from 90 to trunk crashes
> -----------------------------------------------------
>
>                 Key: HBASE-4388
>                 URL: https://issues.apache.org/jira/browse/HBASE-4388
>             Project: HBase
>          Issue Type: Bug
>          Components: master, migration
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>            Assignee: stack
>            Priority: Blocker
>             Fix For: 0.92.0
>
>         Attachments: 4388-v2.txt, 4388-v3.txt, 4388-v4.txt, 4388.txt, 
> hbase-4388-root.dir.tgz, hbase-master-nase.log, meta.tgz
>
>
> I started a trunk cluster to upgrade from 90, inserted a ton of data, then 
> did a clean shutdown. When I started again, I got the following exception:
> 11/09/13 12:29:09 INFO master.HMaster: Meta has HRI with HTDs. Updating meta 
> now.
> 11/09/13 12:29:09 FATAL master.HMaster: Unhandled exception. Starting 
> shutdown.
> java.lang.NegativeArraySizeException: -102
>         at org.apache.hadoop.hbase.util.Bytes.readByteArray(Bytes.java:147)
>         at 
> org.apache.hadoop.hbase.HTableDescriptor.readFields(HTableDescriptor.java:606)
>         at 
> org.apache.hadoop.hbase.migration.HRegionInfo090x.readFields(HRegionInfo090x.java:641)
>         at 
> org.apache.hadoop.hbase.util.Writables.getWritable(Writables.java:133)
>         at 
> org.apache.hadoop.hbase.util.Writables.getWritable(Writables.java:103)
>         at 
> org.apache.hadoop.hbase.util.Writables.getHRegionInfoForMigration(Writables.java:228)
>         at 
> org.apache.hadoop.hbase.catalog.MetaEditor.getHRegionInfoForMigration(MetaEditor.java:350)
>         at 
> org.apache.hadoop.hbase.catalog.MetaEditor$1.visit(MetaEditor.java:273)
>         at 
> org.apache.hadoop.hbase.catalog.MetaReader.fullScan(MetaReader.java:633)
>         at 
> org.apache.hadoop.hbase.catalog.MetaReader.fullScan(MetaReader.java:255)
>         at 
> org.apache.hadoop.hbase.catalog.MetaReader.fullScan(MetaReader.java:235)
>         at 
> org.apache.hadoop.hbase.catalog.MetaEditor.updateMetaWithNewRegionInfo(MetaEditor.java:284)
>         at 
> org.apache.hadoop.hbase.catalog.MetaEditor.migrateRootAndMeta(MetaEditor.java:298)
>         at 
> org.apache.hadoop.hbase.master.HMaster.updateMetaWithNewHRI(HMaster.java:529)
>         at 
> org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:472)
>         at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:309)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to