[ 
https://issues.apache.org/jira/browse/HBASE-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133765#comment-13133765
 ] 

stack commented on HBASE-4447:
------------------------------

@Joep I'm going to revert this change (See Eric's input above).  I also see 
that when you build with mvn 3 it complains:

{code}
pynchon-645:clean-trunk stack$ ~/bin/apache-maven-3.0.3/bin/mvn apache-rat:rat
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for 
org.apache.hbase:hbase:jar:0.93-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ 
org.apache.hbase:hbase:${hbase.version}, 
/Users/stack/checkout/clean-trunk/pom.xml, line 40, column 12
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten 
the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support 
building such malformed projects.
[WARNING] 
{code}

You ok with using the versions plugin as per Eric above?
                
> Allow hbase.version to be passed in as command-line argument
> ------------------------------------------------------------
>
>                 Key: HBASE-4447
>                 URL: https://issues.apache.org/jira/browse/HBASE-4447
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.92.0
>            Reporter: Joep Rottinghuis
>            Assignee: Joep Rottinghuis
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4447-0.92.patch
>
>
> Currently the build always produces the jars and tarball according to the 
> version baked into the POM.
> When we modify this to allow the version to be passed in as a command-line 
> argument, it can still default to the same behavior, yet give the flexibility 
> for an internal build to tag on own version.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to