[ 
https://issues.apache.org/jira/browse/HBASE-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134252#comment-13134252
 ] 

Jean-Daniel Cryans commented on HBASE-4577:
-------------------------------------------

I'm not sure what the best solution is, but I think the current one is 
confusing since both metrics share the same name with only "Uncompressed" being 
different. Looking at the code it seems to be also confused.

The javadoc for Store.getStoreSizeUncompressed:
bq. The size of the store files, in bytes, uncompressed.

And for Store.getStorefilesSize:
bq. The size of the store files, in bytes.

Even the name of the variable is misleading because it's total data size, not 
total size:
bq. totalUncompressedBytes

They read the same, but the first one is really the size of the uncompressed 
data only. I think names should be changed to reflect what they really mean, no 
need for new metrics.
                
> Region server reports storefileSizeMB bigger than storefileUncompressedSizeMB
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-4577
>                 URL: https://issues.apache.org/jira/browse/HBASE-4577
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: gaojinchao
>            Priority: Minor
>             Fix For: 0.92.0
>
>
> Minor issue while looking at the RS metrics:
> bq. numberOfStorefiles=8, storefileUncompressedSizeMB=2418, 
> storefileSizeMB=2420, compressionRatio=1.0008
> I guess there's a truncation somewhere when it's adding the numbers up.
> FWIW there's no compression on that table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to