[ https://issues.apache.org/jira/browse/HBASE-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4627: --------------------------------------- Comment: was deleted (was: nspiegelberg requested code review of "[jira] [HBASE-4627] Ability to specify a custom start/end to RegionSplitter". Reviewers: DUMMY_REVIEWER [HBASE-4627] added a custom start/end row to RegionSplitter. Also solved an off-by-one error because the end row is prefix-inclusive and not exclusive. <a href="https://issues.apache.org/jira/browse/HBASE-4489" title="Better key splitting in RegionSplitter"><del>HBASE-4489</del></a> changed the default endKey on HexStringSplit from 7FFF... to FFFF... While this is correct, existing users of 0.90 RegionSplitter have 7FFF as the end key in their schema and the last region will not split properly under this new code. We need to let the user specify a custom start/end key range for when situations like this arise. Optimally, we should also write the start/end key in META so we could figure this out implicitly instead of requiring the user to explicitly specify it. TEST PLAN - mvn test -Dtest=TestRegionSplitter REVISION DETAIL http://reviews.facebook.net/D39 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/util/Bytes.java src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java MANAGE HERALD DIFFERENTIAL RULES http://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? http://reviews.facebook.net/herald/transcript/75/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. ) > Ability to specify a custom start/end to RegionSplitter > ------------------------------------------------------- > > Key: HBASE-4627 > URL: https://issues.apache.org/jira/browse/HBASE-4627 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.94.0 > Reporter: Nicolas Spiegelberg > Assignee: Nicolas Spiegelberg > Attachments: D39.1.patch, D39.1.patch > > > HBASE-4489 changed the default endKey on HexStringSplit from 7FFF... to > FFFF... While this is correct, existing users of 0.90 RegionSplitter have > 7FFF as the end key in their schema and the last region will not split > properly under this new code. We need to let the user specify a custom > start/end key range for when situations like this arise. Optimally, we > should also write the start/end key in META so we could figure this out > implicitly instead of requiring the user to explicitly specify it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira