[
https://issues.apache.org/jira/browse/HBASE-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740381#comment-14740381
]
Hadoop QA commented on HBASE-14401:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755336/14401v3.txt
against master branch at commit fda317cebb5d306cabf1899e05cedb0225b2b62b.
ATTACHMENT ID: 12755336
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15557//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15557//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15557//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15557//console
This message is automatically generated.
> Stamp failed appends with sequenceid too.... Cleans up latches
> --------------------------------------------------------------
>
> Key: HBASE-14401
> URL: https://issues.apache.org/jira/browse/HBASE-14401
> Project: HBase
> Issue Type: Sub-task
> Components: test, wal
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: 14401.txt, 14401v3.txt, 14401v3.txt
>
>
> Looking in test output I see we can sometimes get stuck waiting on
> sequenceid... The parent issues redo of our semantic makes it so we encounter
> failed append more often around damaged WAL.
> This patch makes it so we stamp sequenceid always, even if the append fails.
> This way all sequenceids are accounted for but more important, the latch on
> sequenceid down in WALKey will be cleared.. where before it was not being
> cleared (there is no global list of outstanding WALKeys waiting on
> sequenceids so no way to clean them up... we don't need such a list if we
> ALWAYS stamp the sequenceid).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
