[
https://issues.apache.org/jira/browse/HBASE-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744155#comment-14744155
]
Hudson commented on HBASE-14306:
--------------------------------
SUCCESS: Integrated in HBase-1.3-IT #152 (See
[https://builds.apache.org/job/HBase-1.3-IT/152/])
HBASE-14306 Refine RegionGroupingProvider: fix issues and make it more scalable
(Yu Li) (tedyu: rev 57679278982fc8e6f7cb2d1c31c9aaf636bd57da)
* hbase-server/src/test/java/org/apache/hadoop/hbase/wal/IOTestProvider.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestBoundedRegionGroupingStrategy.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALFactory.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestBoundedRegionGroupingProvider.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DefaultWALProvider.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRegionGroupingProvider.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALProvider.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
> Refine RegionGroupingProvider: fix issues and make it more scalable
> -------------------------------------------------------------------
>
> Key: HBASE-14306
> URL: https://issues.apache.org/jira/browse/HBASE-14306
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Affects Versions: 2.0.0, 1.1.2
> Reporter: Yu Li
> Assignee: Yu Li
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14306.branch-1.patch, HBASE-14306.patch,
> HBASE-14306_v2.patch, HBASE-14306_v3.patch, HBASE-14306_v3.patch,
> HBASE-14306_v4.patch, HBASE-14306_v5.patch
>
>
> There're multiple issues in RegionGroupingProvider, including:
> * The provider cache in it is using byte array as the key of
> ConcurrentHashMap, which is not right (the reason is
> [here|http://stackoverflow.com/questions/1058149/using-a-byte-array-as-hashmap-key-java])
> * It's using IdentityGroupingStrategy to get group and use it as key of the
> cache, which means the cache will include an entry for each region. This is
> especially unnecessary when using BoundedRegionGroupingProvider
> Besides fixing the above issues, I suggest to change
> BoundedRegionGroupingProvider from a *provider* to a pluggable *strategy*,
> which will make the whole picture much more clear.
> For more details, please refer to the patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
