[ 
https://issues.apache.org/jira/browse/HBASE-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744948#comment-14744948
 ] 

Anoop Sam John commented on HBASE-12298:
----------------------------------------

bq.public abstract void get(byte[] dst, int sourceOffset, int offset, int 
length);

It will be better to keep the dest related param together.  Now in btw that the 
srcOffset is coming.  So
get(int srcOffset, byte[] dst, int offset, int length)  will look better.

Seeing the impl, we do positioning there and then copy and set back old 
position.  Why?  In SBB it is direct copy using the exact offset and no 
positioning is needed at all.  In MBB also we can impl with out positioning?  I 
believe we can easily do that.  In order to save this cost of 2 times 
positioning suggested to have a new API.

> Support BB usage in PrefixTree
> ------------------------------
>
>                 Key: HBASE-12298
>                 URL: https://issues.apache.org/jira/browse/HBASE-12298
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-12298.patch, HBASE-12298_1.patch, 
> HBASE-12298_2.patch, HBASE-12298_3.patch, HBASE-12298_4 (1).patch, 
> HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch, 
> HBASE-12298_4 (1).patch, HBASE-12298_4.patch, HBASE-12298_4.patch, 
> HBASE-12298_4.patch, HBASE-12298_4.patch, HBASE-12298_5.patch, 
> HBASE-12298_6.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to