[ https://issues.apache.org/jira/browse/HBASE-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745025#comment-14745025 ]
Hudson commented on HBASE-14401: -------------------------------- FAILURE: Integrated in HBase-1.2 #171 (See [https://builds.apache.org/job/HBase-1.2/171/]) HBASE-14401 Stamp failed appends with sequenceid too.... Cleans up latches (stack: rev 481d3f43504114f630d8dc319705f1aecc7a45db) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFailedAppendAndSync.java * hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java > Stamp failed appends with sequenceid too.... Cleans up latches > -------------------------------------------------------------- > > Key: HBASE-14401 > URL: https://issues.apache.org/jira/browse/HBASE-14401 > Project: HBase > Issue Type: Sub-task > Components: test, wal > Reporter: stack > Assignee: stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 14401.txt, 14401.v7.txt, 14401.v7.txt, 14401.v7.txt, > 14401v3.txt, 14401v3.txt, 14401v3.txt, 14401v6.txt > > > Looking in test output I see we can sometimes get stuck waiting on > sequenceid... The parent issues redo of our semantic makes it so we encounter > failed append more often around damaged WAL. > This patch makes it so we stamp sequenceid always, even if the append fails. > This way all sequenceids are accounted for but more important, the latch on > sequenceid down in WALKey will be cleared.. where before it was not being > cleared (there is no global list of outstanding WALKeys waiting on > sequenceids so no way to clean them up... we don't need such a list if we > ALWAYS stamp the sequenceid). -- This message was sent by Atlassian JIRA (v6.3.4#6332)