[ https://issues.apache.org/jira/browse/HBASE-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746460#comment-14746460 ]
Hadoop QA commented on HBASE-14145: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12756091/HBASE-14145-v2.patch against master branch at commit 938d2a0c9cfa4c033ccc72de490672f151bb0351. ATTACHMENT ID: 12756091 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 1837 checkstyle errors (more than the master's current 1835 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + tasks.add(new RegionServerTask(this.connection, serverName, region, getSink(), successes)); + tasks.add(new RegionServerTask(this.connection, serverName, region, getSink(), successes)); {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.TestChoreService.testForceTrigger(TestChoreService.java:379) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15610//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15610//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15610//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15610//console This message is automatically generated. > Allow the Canary in regionserver mode to try all regions on the server, not > just one > ------------------------------------------------------------------------------------ > > Key: HBASE-14145 > URL: https://issues.apache.org/jira/browse/HBASE-14145 > Project: HBase > Issue Type: Bug > Components: canary, util > Affects Versions: 2.0.0, 1.1.0.1 > Reporter: Elliott Clark > Assignee: Sanjeev Srivatsa > Labels: beginner > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14145-v1.patch, HBASE-14145-v2.patch, > HBASE-14145-v2.patch, testrun.txt, testrun2.txt > > > We want a pretty in-depth canary that will try every region on a cluster. > When doing that for the whole cluster one machine is too slow, so we wanted > to split it up and have each regionserver run a canary. That works however > the canary does less work as it just tries one random region. > Lets add a flag that will allow the canary to try all regions on a > regionserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)