[ 
https://issues.apache.org/jira/browse/HBASE-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876241#comment-14876241
 ] 

Ted Yu commented on HBASE-14449:
--------------------------------

Ran the failed tests shown above locally which passed.

TestMasterMetricsWrapper passes in the above QA run.

> Rewrite deadlock prevention due to concurrent connection close
> --------------------------------------------------------------
>
>                 Key: HBASE-14449
>                 URL: https://issues.apache.org/jira/browse/HBASE-14449
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
>         Attachments: 14449-branch-1.0.txt, 14449-v1.txt
>
>
> The deadlock prevention approach used in HBASE-14241 introduces unnecessary 
> logic which is not intuitive.
> Depending on the value for config hbase.ipc.client.specificThreadForWriting , 
> there may or may not be CallSender threads running.
> The attached patch simplifies deadlock prevention by using a Set which 
> represents the Connections to be closed. Outside the synchronized 
> (connections) block, this Set is iterated where the Connections are closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to