[
https://issues.apache.org/jira/browse/HBASE-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903020#comment-14903020
]
Heng Chen commented on HBASE-14455:
-----------------------------------
{quote}
Why move setupClusterConnection(); into createServerManager though? (I can try
and guess but let me ask instead).
{quote}
Because {{ServerManager}} will reuse {{HMaster}} connection instance, to avoid
creating {{ServerManager}} with an uninitialized connection, i move
setupClusterConnection(); into createServerManager();
> Try to get rid of unused HConnection instance
> ----------------------------------------------
>
> Key: HBASE-14455
> URL: https://issues.apache.org/jira/browse/HBASE-14455
> Project: HBase
> Issue Type: Improvement
> Reporter: Heng Chen
> Priority: Minor
> Attachments: HBASE-14455.patch
>
>
> After HBASE-14361, we get rid of HConnection Instance in ReplicationSink in
> standalone mode. But there are still three HConnection Instance, i think the
> unused ones should be removed.
> The three instances are created below
> {code}
> 6 2015-09-21 16:05:36,401 INFO [10.0.3.80:60429.activeMasterManager]
> client.ConnectionImplementation:.
> 7 java.lang.Throwable
> 8 >---at
> org.apache.hadoop.hbase.client.ConnectionImplementation.<init>(ConnectionImplementation.java:217)
> 9 >---at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> 10 >---at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> 11 >---at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 12 >---at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
> 13 >---at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:231)
> 14 >---at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:118)
> 15 >---at
> org.apache.hadoop.hbase.master.ServerManager.<init>(ServerManager.java:222)
> 16 >---at
> org.apache.hadoop.hbase.master.ServerManager.<init>(ServerManager.java:212)
> 17 >---at
> org.apache.hadoop.hbase.master.HMaster.createServerManager(HMaster.java:853)
> 18 >---at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:661)
> 19 >---at
> org.apache.hadoop.hbase.master.HMaster.access$500(HMaster.java:180)
> 20 >---at org.apache.hadoop.hbase.master.HMaster$1.run(HMaster.java:1670)
> 21 >---at java.lang.Thread.run(Thread.java:745)
> 22 2015-09-21 16:05:36,401 INFO [M:0;10.0.3.80:60429]
> client.ConnectionImplementation:.
> 23 java.lang.Throwable
> 24 >---at
> org.apache.hadoop.hbase.client.ConnectionImplementation.<init>(ConnectionImplementation.java:217)
> 25 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils$1.<init>(ConnectionUtils.java:128)
> 26 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils.createShortCircuitConnection(ConnectionUtils.java:128)
> 27 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.createClusterConnection(HRegionServer.java:686)
> 28 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.setupClusterConnection(HRegionServer.java:717)
> 29 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:730)
> 30 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:885)
> 31 >---at
> org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.run(HMasterCommandLine.java:311)
> 32 >---at java.lang.Thread.run(Thread.java:745)
> 33 2015-09-21 16:05:36,401 INFO [RS:0;10.0.3.80:60431]
> client.ConnectionImplementation:.
> 34 java.lang.Throwable
> 35 >---at
> org.apache.hadoop.hbase.client.ConnectionImplementation.<init>(ConnectionImplementation.java:217)
> 36 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils$1.<init>(ConnectionUtils.java:128)
> 37 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils.createShortCircuitConnection(ConnectionUtils.java:128)
> 38 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.createClusterConnection(HRegionServer.java:686)
> 39 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.setupClusterConnection(HRegionServer.java:717)
> 40 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:730)
> 41 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:885)
> 42 >---at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
