[
https://issues.apache.org/jira/browse/HBASE-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903393#comment-14903393
]
stack commented on HBASE-14451:
-------------------------------
Thanks for the nice review [~cmccabe]
First up, doing a convertion job first to just get us up on to 4.0.0.
Improvements will be done in later JIRA including telling good story.
bq. ResultBoundedCompletionService: it seems like Tracer should be an argument
to the constructor here, rather than pulled from Tracer#curThreadTracer.
This looks like a good place to use Tracer.curThreadTracer. We are way down in
the stack doing an exotic call.
Changed around the highs and lows for traceid and parent as per your suggestion.
Removed tracedWriteRequest as per your suggestion (good one).
RpcClientImpl and RZK are used in a few places and are buried deep. Seems like
good place for Tracer.curThreadTracer.... (thats what it was before in essence)
Added samplers to hbase-default.
Will do a review after this convertion patch to try and do more explicit Tracer
instance passing.
A master is a regionserver so it gets the regionserver Tracer. Client tracer
setup is done in hbase shell -- over in ruby code. I had not converted that.
Will include in next patch. Thanks.
bq, RingBufferTruck: I thought HBase was more of a series of tubes?
We carry freight.
> Move on to htrace-4.0.0 (from htrace-3.2.0)
> -------------------------------------------
>
> Key: HBASE-14451
> URL: https://issues.apache.org/jira/browse/HBASE-14451
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Attachments: 14451.txt, 14451v2.txt, 14451v3.txt, 14451v4.txt,
> 14451v5.txt, 14451v6.txt, 14451v7.txt
>
>
> htrace-4.0.0 was just release with a new API. Get up on it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
