[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905429#comment-14905429 ]
Nick Dimiduk commented on HBASE-14394: -------------------------------------- Hi [~srikanth235]. While prepping for 1.1.3 release, I noticed this patch added TableRecordReader#setConnection as a public method with no Javadoc string. This is a @InterfaceAudience.Public, @InterfaceStability.Stable class, which means it's now and forever part of our public, stable API. Thus I have to ask: can it's visibility be reduced and can you please provide a basic docstring explaining when and where it needs to be used? Maybe [~jerryhe] can provide some context here as well. Thanks. > Properly close the connection after reading records from table. > --------------------------------------------------------------- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug > Reporter: Srikanth Srungarapu > Assignee: Srikanth Srungarapu > Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)