[ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907879#comment-14907879 ]
Hadoop QA commented on HBASE-14490: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12762355/HBASE-14490-v1.patch against master branch at commit a33adf2f0b050e9cf9330fd5ab7e200a7dd27d6d. ATTACHMENT ID: 12762355 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.ipc.TestAsyncIPC org.apache.hadoop.hbase.security.TestSecureRPC org.apache.hadoop.hbase.ipc.TestIPC {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot.testLoadImageWithAppending(TestFSImageWithSnapshot.java:411) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15738//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15738//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15738//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15738//console This message is automatically generated. > [RpcServer] reuse buffer and more stricter code > ----------------------------------------------- > > Key: HBASE-14490 > URL: https://issues.apache.org/jira/browse/HBASE-14490 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Reporter: Zephyr Guo > Assignee: Zephyr Guo > Attachments: HBASE-14490-v1.patch, Test.java > > > 1.Reuse buffer to read request. > It's not necessary free data's buffer for each request. > 2.There are hidden trouble in socket IO with non-blocking mode. > We just use *channel.read(byteBuffer)* to read data of > request(byteBuffer.limit=dataLength).We need *dataLength* bytes but read > maybe not fill the *byteBuffer*. > The link is the *read(byteBuffer)* method > describe:http://docs.oracle.com/javase/7/docs/api/java/nio/channels/SocketChannel.html#read(java.nio.ByteBuffer) > I write a sample to test it(Test.java). > 3.*channelIO()* method return value > More stricter return value. > So I rewrite *channelIO*.It can work well with non-blocking and back small > IO(size<NIO_BUFFER_LIMIT) or large. -- This message was sent by Atlassian JIRA (v6.3.4#6332)