[ 
https://issues.apache.org/jira/browse/HBASE-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909599#comment-14909599
 ] 

Hadoop QA commented on HBASE-14406:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12762569/HBASE-14406.3.patch
  against master branch at commit 526520de0a9d7a29fcf1b4c521f017ca75a46cbc.
  ATTACHMENT ID: 12762569

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping 
cell_to_column_mapping = 3;</code>

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15768//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15768//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15768//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15768//console

This message is automatically generated.

> The dataframe datasource filter is wrong, and will result in data loss or 
> unexpected behavior
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14406
>                 URL: https://issues.apache.org/jira/browse/HBASE-14406
>             Project: HBase
>          Issue Type: Bug
>          Components: spark
>    Affects Versions: 2.0.0
>            Reporter: Zhan Zhang
>            Assignee: Ted Malaska
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14406.1.patch, HBASE-14406.2.patch, 
> HBASE-14406.3.patch
>
>
> Following condition will result in the same filter. It will have data loss 
> with the current filter construction.
> col1 > 4 && col2 < 3
> col1 > 4 || col2 < 3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to