[ https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136563#comment-13136563 ]
jirapos...@reviews.apache.org commented on HBASE-4605: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2579/#review2870 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/constraint/ConstraintProcessor.java <https://reviews.apache.org/r/2579/#comment6424> This condition can be expressed as !constraints.isEmpty() src/main/java/org/apache/hadoop/hbase/constraint/ConstraintProcessor.java <https://reviews.apache.org/r/2579/#comment6423> Please use curly braces for line 60. This log can be combined with log on line 63. src/main/java/org/apache/hadoop/hbase/constraint/ConstraintProcessor.java <https://reviews.apache.org/r/2579/#comment6425> This has been done, right ? src/main/java/org/apache/hadoop/hbase/constraint/ConstraintProcessor.java <https://reviews.apache.org/r/2579/#comment6426> Contents of put should be included. src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java <https://reviews.apache.org/r/2579/#comment6427> We can either add removeCoprocessor() to HTD or, persist a flag to tell ConstraintProcessor that it is disabled. I think the second approach may be better in our case. src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java <https://reviews.apache.org/r/2579/#comment6428> Should be 'desc HTableDescriptor to read from' - Ted On 2011-10-26 22:34:35, Jesse Yates wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2579/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-10-26 22:34:35) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Most of the implementation for adding constraints as a coprocessor. bq. bq. Looking for general comments on style/structure, though nitpicks are ok too. bq. bq. Currently missing implementation for disableConstraints() since that will require adding removeCoprocessor() to HTD (also comments on if this is worth it would be good). bq. bq. bq. This addresses bug HBASE-4605. bq. https://issues.apache.org/jira/browse/HBASE-4605 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/constraint/ConstraintProcessor.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/constraint/IntegerConstraint.java PRE-CREATION bq. src/test/java/org/apache/hadoop/hbase/constraint/IntegrationTestConstraint.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/2579/diff bq. bq. bq. Testing bq. ------- bq. bq. Adding IntegrationTestConstraint and unit tests for Constraints and IntegerConstraint. All of those pass. bq. bq. bq. Thanks, bq. bq. Jesse bq. bq. > Constraints > ----------- > > Key: HBASE-4605 > URL: https://issues.apache.org/jira/browse/HBASE-4605 > Project: HBase > Issue Type: Improvement > Components: client, coprocessors > Affects Versions: 0.94.0 > Reporter: Jesse Yates > Assignee: Jesse Yates > Attachments: constraint_as_cp.txt, java_Constraint_v2.patch > > > From Jesse's comment on dev: > {quote} > What I would like to propose is a simple interface that people can use to > implement a 'constraint' (matching the classic database definition). This > would help ease of adoption by helping HBase more easily check that box, help > minimize code duplication across organizations, and lead to easier adoption. > Essentially, people would implement a 'Constraint' interface for checking > keys before they are put into a table. Puts that are valid get written to the > table, but if not people can will throw an exception that gets propagated > back to the client explaining why the put was invalid. > Constraints would be set on a per-table basis and the user would be expected > to ensure the jars containing the constraint are present on the machines > serving that table. > Yes, people could roll their own mechanism for doing this via coprocessors > each time, but this would make it easier to do so, so you only have to > implement a very minimal interface and not worry about the specifics. > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira