[ 
https://issues.apache.org/jira/browse/HBASE-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated HBASE-14539:
----------------------------------
    Attachment: 14539-0.98.txt

Here's a trivial patch. Makes absolutely sure we do no work (other than the 
compares in the switch statements) unless we need to do any.

I measured a 3-5% improvement in some cases.

Trivial patch, no functional change. Will commit tomorrow unless I hear 
objections.

> Slight improvement of StoreScanner.optimize
> -------------------------------------------
>
>                 Key: HBASE-14539
>                 URL: https://issues.apache.org/jira/browse/HBASE-14539
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 0.98.15, 1.2.1, 1.0.3, 1.1.3
>
>         Attachments: 14539-0.98.txt
>
>
> While looking at the code I noticed that StoreScanner.optimize does not some 
> unnecessary work. This is a very tight loop and even just looking up a 
> reference can throw off the CPUs cache lines. This does safe a few percent of 
> performance (not a lot, though).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to