[ 
https://issues.apache.org/jira/browse/HBASE-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945889#comment-14945889
 ] 

Jonathan Hsieh commented on HBASE-12615:
----------------------------------------

Wow that is a lot of trailing space removal.

caught this in one of them:
nit : This will output smt like: -> This will output something like:

lgtm +1.

> Document GC conserving guidelines for contributors
> --------------------------------------------------
>
>                 Key: HBASE-12615
>                 URL: https://issues.apache.org/jira/browse/HBASE-12615
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Andrew Purtell
>            Assignee: Misty Stanley-Jones
>         Attachments: HBASE-12615.patch
>
>
> LinkedIn put up a blog post with a nice concise list of GC conserving 
> techniques we should document for contributors. Additionally, when we're at a 
> point our build supports custom error-prone plugins, we can develop warnings 
> for some of them. 
> Source: 
> http://engineering.linkedin.com/performance/linkedin-feed-faster-less-jvm-garbage
> - Be careful with Iterators
> - Estimate the size of a collection when initializing
> - Defer expression evaluation
> - Compile the regex patterns in advance
> - Cache it if you can
> - String Interns are useful but dangerous
> All good advice and practice that I know we aim for. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to