[ 
https://issues.apache.org/jira/browse/HBASE-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961462#comment-14961462
 ] 

Andrew Purtell commented on HBASE-14613:
----------------------------------------

bq. I am always dubious about trying to be smarter than the GC. Extra 
management, the requirement to get the number of chunks right to be useful but 
not wasteful, etc.

Generally agreed. Given that there's unnecessary complexity in this code. 

If we ever do direct offheap allocation in memstore, with all that implies, 
then we'd want to use pooling and refcounting. Until then? 


> Remove MemStoreChunkPool?
> -------------------------
>
>                 Key: HBASE-14613
>                 URL: https://issues.apache.org/jira/browse/HBASE-14613
>             Project: HBase
>          Issue Type: Brainstorming
>            Reporter: Lars Hofhansl
>            Priority: Minor
>         Attachments: 14613-0.98.txt
>
>
> I just stumbled across MemStoreChunkPool. The idea behind is to reuse chunks 
> of allocations rather than letting the GC handle this.
> Now, it's off by default, and it seems to me to be of dubious value. I'd 
> recommend just removing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to