[ https://issues.apache.org/jira/browse/HBASE-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966399#comment-14966399 ]
Heng Chen commented on HBASE-14635: ----------------------------------- As this testcase, i found some flakey code which i can't understand. {code} SnapshotTestingUtils.createSnapshotAndValidate(admin, localTableName, TEST_FAM_STR, snapshotNameAsString, rootDir, fs, online); if (!online) { tryDisable(admin, localTableName); //Why we disable again ? ? ? } {code} As comments of {{SnapshotTestingUtils.createSnapshotAndValidate}} , if online be false, the function will disable {{localTable}}, why disable again? And after disable the table, {{admin.majorCompact(localTableName)}} was called. Is it right? It seems to replace "disable" action to be "enable" action? > Reenable TestSnapshotCloneIndependence.testOnlineSnapshotDeleteIndependent > -------------------------------------------------------------------------- > > Key: HBASE-14635 > URL: https://issues.apache.org/jira/browse/HBASE-14635 > Project: HBase > Issue Type: Sub-task > Components: test > Reporter: stack > Fix For: 2.0.0, 1.2.0, 1.3.0 > > > Was disabled in the parent issue because flakey. This issue is about > reenabling it after figuring why its flakey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)