[ https://issues.apache.org/jira/browse/HBASE-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970450#comment-14970450 ]
stack commented on HBASE-14660: ------------------------------- This is too much information.... 956 if (this.curBlock.usesSharedMemory()) { 957 if (currTagsLen > 0) { 958 ret = new ShareableMemoryKeyValue(buf.array(), buf.arrayOffset() + buf.position(), 959 cellBufSize, seqId); 960 } else { 961 ret = new ShareableMemoryNoTagsKeyValue(buf.array(), 962 buf.arrayOffset() + buf.position(), cellBufSize, seqId); 963 } 964 } else { 965 if (currTagsLen > 0) { 966 ret = new SizeCachedKeyValue(buf.array(), buf.arrayOffset() + buf.position(), 967 cellBufSize, seqId); 968 } else { 969 ret = new SizeCachedNoTagsKeyValue(buf.array(), buf.arrayOffset() + buf.position(), 970 cellBufSize, seqId); 971 } 972 } Can we hide it? This kind of decision tree is going to be repeated throughout codebase? > AssertionError found when using offheap BucketCache with assertion enabled > -------------------------------------------------------------------------- > > Key: HBASE-14660 > URL: https://issues.apache.org/jira/browse/HBASE-14660 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0 > Reporter: Yu Li > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-14660.patch, HBASE-14660_1.patch, > HBASE-14660_2.patch > > > During perf verification of HBASE-14463, found offheap BucketCache not > working with assertion enabled in hbase-env.sh: > {noformat} > export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError > -XX:+UseConcMarkSweepGC" > {noformat} > And the error when running PE tool is like: > {noformat} > 15/10/21 16:06:34 INFO client.AsyncProcess: #10, table=TestTable, > attempt=10/21 failed=20ops, last exception: java.io.IOException: > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2181) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:106) > at > org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130) > at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107) > at java.lang.Thread.run(Thread.java:744) > Caused by: java.lang.AssertionError > at > org.apache.hadoop.hbase.OffheapKeyValue.<init>(OffheapKeyValue.java:52) > at > org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl$ShareableMemoryOffheapKeyValue.<init>(HFileReaderImpl.java:1003) > at > org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.getCell(HFileReaderImpl.java:949) > at > org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(StoreFileScanner.java:201) > at > org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(NonLazyKeyValueScanner.java:55) > at > org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:323) > at > org.apache.hadoop.hbase.regionserver.KeyValueHeap.requestSeek(KeyValueHeap.java:279) > at > org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:825) > at > org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:813) > at > org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:641) > at > org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:153) > at > org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:5649) > at > org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:5795) > at > org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:5568) > at > org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:5544) > at > org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:5530) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2044) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:663) > at > org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2156) > {noformat} > [~ram_krish] and [~anoop.hbase], mind to take a look? -- This message was sent by Atlassian JIRA (v6.3.4#6332)