[ 
https://issues.apache.org/jira/browse/HBASE-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972413#comment-14972413
 ] 

Hadoop QA commented on HBASE-14676:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12768476/14676v4.txt
  against master branch at commit 8b7796b0b661ca960463c9e16034ee8f64494dbd.
  ATTACHMENT ID: 12768476

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 26 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16208//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16208//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16208//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16208//console

This message is automatically generated.

> HBaseTestCase clean out: Purge Incommon Interface and Table and Region 
> implementations
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-14676
>                 URL: https://issues.apache.org/jira/browse/HBASE-14676
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 14676.patch, 14676v2.txt, 14676v3.txt, 14676v4.txt, 
> RegionAdmin.java
>
>
> As part of the hollowing out of the old HBaseTestCase in preparation for 
> removal, this patch purges the old Incommon trick that made it so you could 
> pass an Interface to a method to do loading or testing and the implementation 
> could be an HTable or a Region.  Instead, replace it with a RegionTable, a 
> Regoin that has the Table Interface as a decoration so you can use same 
> loading code and same test both on top of the Region or on other side of 
> network via HTable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to