[
https://issues.apache.org/jira/browse/HBASE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139515#comment-13139515
]
Hadoop QA commented on HBASE-4298:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501479/4298-trunk-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -166 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/102//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/102//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/102//console
This message is automatically generated.
> Support to drain RS nodes through ZK
> ------------------------------------
>
> Key: HBASE-4298
> URL: https://issues.apache.org/jira/browse/HBASE-4298
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.90.4
> Environment: all
> Reporter: Aravind Gottipati
> Priority: Critical
> Labels: patch
> Fix For: 0.92.0, 0.90.5
>
> Attachments: 4298-trunk-v2.txt, 90_hbase.patch, trunk_hbase.patch
>
>
> HDFS currently has a way to exclude certain datanodes and prevent them from
> getting new blocks. HDFS goes one step further and even drains these nodes
> for you. This enhancement is a step in that direction.
> The idea is that we mark nodes in zookeeper as draining nodes. This means
> that they don't get any more new regions. These draining nodes look exactly
> the same as the corresponding nodes in /rs, except they live under /draining.
> Eventually, support for draining them can be added. I am submitting two
> patches for review - one for the 0.90 branch and one for trunk (in git).
> Here are the two patches
> 0.90 -
> https://github.com/aravind/hbase/commit/181041e72e7ffe6a4da6d82b431ef7f8c99e62d2
> trunk -
> https://github.com/aravind/hbase/commit/e127b25ae3b4034103b185d8380f3b7267bc67d5
> I have tested both these patches and they work as advertised.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
