[
https://issues.apache.org/jira/browse/HBASE-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhishek Singh Chouhan updated HBASE-14728:
-------------------------------------------
Attachment: HBASE-14728.patch
> TestRowCounter is broken in master
> ----------------------------------
>
> Key: HBASE-14728
> URL: https://issues.apache.org/jira/browse/HBASE-14728
> Project: HBase
> Issue Type: Test
> Affects Versions: 2.0.0
> Reporter: Abhishek Singh Chouhan
> Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-14728.patch, HBASE-14728.patch
>
>
> The runRowCount method simply runs the RowCounter and checks if the exit code
> is zero but does not actually check the row count returned
> {noformat}
> private void runRowCount(String[] args, int expectedCount) throws Exception {
> final RowCounter counter = new RowCounter();
> assertEquals("job failed either due to failure or miscount (see log
> output).", 0,
> ToolRunner.run(TEST_UTIL.getConfiguration(), counter, args));
> }
> {noformat}
> This will always give a false positive provided the job ran without errors
> (irrespective of the count it gives).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
