[
https://issues.apache.org/jira/browse/HBASE-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995932#comment-14995932
]
stack commented on HBASE-14784:
-------------------------------
Any chance of a test? Would help prevent regression. Thanks for the patch
anyways.
> Port conflict is not resolved in HBaseTestingUtility.randomFreePort()
> ---------------------------------------------------------------------
>
> Key: HBASE-14784
> URL: https://issues.apache.org/jira/browse/HBASE-14784
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 1.1.2
> Reporter: Youngjoon Kim
> Assignee: Youngjoon Kim
> Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14784.patch
>
>
> If takenRandomPorts.contains(port) == true, it means port conflict, so
> randomFreePort() should rerun the loop. But continue statement leads to exit
> the loop, because port != 0.
> {code:title=hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java}
> public static int randomFreePort() {
> int port = 0;
> do {
> port = randomPort();
> if (takenRandomPorts.contains(port)) {
> continue;
> }
> takenRandomPorts.add(port);
> ...
> } while (port == 0);
> return port;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
