[ 
https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006513#comment-15006513
 ] 

Heng Chen commented on HBASE-14803:
-----------------------------------

Oh,  the patch will cause 
org.apache.hadoop.hbase.regionserver.TestRecoveredEdits timeout!
Maybe that is why there is NO logs in StoreFileScanner,  it dumps too many....

{code}
testReplayWorksThoughLotsOfFlushing(org.apache.hadoop.hbase.regionserver.TestRecoveredEdits)
  Time elapsed: 60.083 sec  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 60000 
milliseconds
        at java.lang.Throwable.getStackTraceElement(Native Method)
        at java.lang.Throwable.getOurStackTrace(Throwable.java:827)
        at java.lang.Throwable.getStackTrace(Throwable.java:816)
        at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.apache.log4j.spi.LocationInfo.<init>(LocationInfo.java:139)
        at 
org.apache.log4j.spi.LoggingEvent.getLocationInformation(LoggingEvent.java:253)
        at 
org.apache.log4j.helpers.PatternParser$ClassNamePatternConverter.getFullyQualifiedName(PatternParser.java:555)
        at 
org.apache.log4j.helpers.PatternParser$NamedPatternConverter.convert(PatternParser.java:528)
        at 
org.apache.log4j.helpers.PatternConverter.format(PatternConverter.java:65)
        at org.apache.log4j.PatternLayout.format(PatternLayout.java:506)
        at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:310)
        at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
        at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
        at 
org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
        at org.apache.log4j.Category.callAppenders(Category.java:206)
        at org.apache.log4j.Category.forcedLog(Category.java:391)
        at org.apache.log4j.Category.log(Category.java:856)
        at 
org.apache.commons.logging.impl.Log4JLogger.debug(Log4JLogger.java:155)
        at 
org.apache.hadoop.hbase.regionserver.StoreFileScanner.shouldUseScanner(StoreFileScanner.java:455)
        at 
org.apache.hadoop.hbase.regionserver.StoreScanner.selectScannersFrom(StoreScanner.java:397)
        at 
org.apache.hadoop.hbase.regionserver.StoreScanner.getScannersNoCompaction(StoreScanner.java:316)
        at 
org.apache.hadoop.hbase.regionserver.StoreScanner.<init>(StoreScanner.java:196)
        at 
org.apache.hadoop.hbase.regionserver.HStore.createScanner(HStore.java:1953)
        at 
org.apache.hadoop.hbase.regionserver.HStore.getScanner(HStore.java:1943)
        at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.<init>(HRegion.java:5494)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.instantiateRegionScanner(HRegion.java:2522)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2508)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2489)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2485)
        at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:6648)
        at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:6613)
        at 
org.apache.hadoop.hbase.regionserver.TestRecoveredEdits.verifyAllEditsMadeItIn(TestRecoveredEdits.java:171)
        at 
org.apache.hadoop.hbase.regionserver.TestRecoveredEdits.testReplayWorksThoughLotsOfFlushing(TestRecoveredEdits.java:134)
{code}

> Add some debug logs to StoreFileScanner
> ---------------------------------------
>
>                 Key: HBASE-14803
>                 URL: https://issues.apache.org/jira/browse/HBASE-14803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>             Fix For: 1.2.0
>
>         Attachments: HBASE-14803.v0-trunk.patch, HBASE-14803.v1-trunk.patch, 
> HBASE-14803.v2-trunk.patch, HBASE-14803.v3-trunk.patch, 
> HBASE-14803.v4-trunk.patch, HBASE-14803.v4-trunk.patch
>
>
> To validate some behaviors I had to add some logs into StoreFileScanner.
> I think it can be interesting for other people looking for debuging. So 
> sharing the modifications here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to