[ https://issues.apache.org/jira/browse/HBASE-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008335#comment-15008335 ]
Appy commented on HBASE-14793: ------------------------------ Hmm..this is new to me. Is {{CACHE_FIXED_OVERHEAD}} tracking the size of LruBlockCache class? If yes, am confused why are we incrementing {{ClassSize.REFERENCE}} instead of {{Bytes.SIZEOF_LONG}}. To make sure if it was really tracking size of the class, I tried to cross-check class members with the count for each type. Seems like the count for boolean is wrong. {{forceInMemory}} was added in HBASE-10263 but isn't accounted. It's a one line change. In case you update the patch, can you please fix that too. > Allow limiting size of block into L1 block cache. > ------------------------------------------------- > > Key: HBASE-14793 > URL: https://issues.apache.org/jira/browse/HBASE-14793 > Project: HBase > Issue Type: Bug > Affects Versions: 1.2.0, 1.1.2 > Reporter: Elliott Clark > Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14793-v1.patch, HBASE-14793-v3.patch, > HBASE-14793-v4.patch, HBASE-14793-v5.patch, HBASE-14793-v6.patch, > HBASE-14793.patch > > > G1GC does really badly with long lived large objects. Lets allow limiting the > size of a block that can be kept in the block cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)