[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011388#comment-15011388
]
stack commented on HBASE-14575:
-------------------------------
bq. The explanation is pretty long. How about putting the explanation in
description of this JIRA and refer to JIRA number in the patch ?
Put in the code I'd say. Thats where folks will be looking for description of
locking regime. Here it will just rot. Can add (with update) on commit.
Your ITBLL numbers are a little odd but fine. Any exceptions in regionserver
logs?
I'd be game for trying this patch... do it in master and in branch-1 -- not 1.2
-- so we have time to see if any issues arise.
> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
> Key: HBASE-14575
> URL: https://issues.apache.org/jira/browse/HBASE-14575
> Project: HBase
> Issue Type: Sub-task
> Components: Compaction, regionserver
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Attachments: 14575-test-case.patch, 14575-v1.patch, 14575-v2.patch,
> 14575-v3.patch, 14575-v4.patch, 14575-v5.patch, 14575-v6.txt, 14575-v6.txt,
> 14575-v6.txt, 14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope
> of critical section under which compactions hold the region read lock.
> Here is summary from parent issue:
> Another idea is we can reduce the scope of when the read lock is held during
> compaction. In theory the compactor only needs a region read lock while
> deciding what files to compact and at the time of committing the compaction.
> We're protected from the case of region close events because compactions are
> checking (every 10k bytes written) if the store has been closed in order to
> abort in such a case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
