[
https://issues.apache.org/jira/browse/HBASE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141387#comment-13141387
]
jirapos...@reviews.apache.org commented on HBASE-4553:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2656/
-----------------------------------------------------------
(Updated 2011-11-01 17:52:00.184660)
Review request for hbase.
Changes
-------
Updated diff; more javadoc and tests.
Summary
-------
Retry.
This addresses bug hbase-4553.
https://issues.apache.org/jira/browse/hbase-4553
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 46ca765
src/main/java/org/apache/hadoop/hbase/HConstants.java 76278a2
src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
b9d4b90
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 24570c9
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 36d90c3
src/main/java/org/apache/hadoop/hbase/util/HMerge.java a6f6b69
src/main/java/org/apache/hadoop/hbase/util/Merge.java 3aa980f
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 0a6f703
src/test/java/org/apache/hadoop/hbase/TestFSTableDescriptorForceCreation.java
8404d1b
src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 49bcf02
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
b2cb233
src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java
8fce6ec
src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java 1ad30e6
src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java 21a57ca
src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java e4b3d75
Diff: https://reviews.apache.org/r/2656/diff
Testing
-------
Thanks,
Michael
> The update of .tableinfo is not atomic; we remove then rename
> -------------------------------------------------------------
>
> Key: HBASE-4553
> URL: https://issues.apache.org/jira/browse/HBASE-4553
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3446-v8.txt, 4553-v10.txt, 4553-v5.txt, 4553-v9.txt,
> HBase-4553-TestAvroServer.patch
>
>
> This comes of HBASE-4547. The rename in 0.20 hdfs fails if file exists
> already. In 0.20+ its better but still 'some' issues if existing reader when
> file is renamed. This issue is about fixing this (though we depend on fix
> first being in hdfs).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
