[ https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141389#comment-13141389 ]
Todd Lipcon commented on HBASE-4716: ------------------------------------ - style: should move "if" statement bodies to own line with braces around them - can you refactor the new loop to a function like isSingleFamilyBulkLoad(familyPaths) so the code reads more clearly? - in the case that this.closed flips true, it's calling lock.writeLock.unlock() even if lock.readLock was taken. That's not correct. Like I said in the earlier review, I think it would be better to add a new function: startRegionOperation(LockMode mode) {...} with enum LockMode { WRITE, READ } ...so you don't have these types of bugs. > Improve locking for single column family bulk load > -------------------------------------------------- > > Key: HBASE-4716 > URL: https://issues.apache.org/jira/browse/HBASE-4716 > Project: HBase > Issue Type: Bug > Affects Versions: 0.92.0 > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 0.92.0 > > Attachments: 4716.txt > > > HBASE-4552 changed the locking behavior for single column family bulk load, > namely we don't need to take write lock. > A read lock would suffice. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira