[ https://issues.apache.org/jira/browse/HBASE-13153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020709#comment-15020709 ]
Appy commented on HBASE-13153: ------------------------------ The difference is because hadoop QA compares total number of error across all files where as the tool checks at file level. Adding the numbers given by tool, there are 26 new errors. The patch probably fixed 16 errors in some other files, which is why hadoop qa shows only +10 increase. As you can see, looking at overall count like presubmit does isn't the best way, HBASE-14859 will fix it. As for the exact errors, it's my fault for not setting indentations for all options to 2. When i was setting it, I looked at couple of code examples, and seemed like 4 was standard. Same for imports. For now, updated hee patch in HBASE-14859 to only check for common things between idea and eclipse. Help review and submit? :-) [~ashish singhi] Sorry for the trouble. :-( > Bulk Loaded HFile Replication > ----------------------------- > > Key: HBASE-13153 > URL: https://issues.apache.org/jira/browse/HBASE-13153 > Project: HBase > Issue Type: New Feature > Components: Replication > Reporter: sunhaitao > Assignee: Ashish Singhi > Fix For: 2.0.0 > > Attachments: HBASE-13153-v1.patch, HBASE-13153-v10.patch, > HBASE-13153-v11.patch, HBASE-13153-v12.patch, HBASE-13153-v13.patch, > HBASE-13153-v14.patch, HBASE-13153-v15.patch, HBASE-13153-v16.patch, > HBASE-13153-v17.patch, HBASE-13153-v18.patch, HBASE-13153-v2.patch, > HBASE-13153-v3.patch, HBASE-13153-v4.patch, HBASE-13153-v5.patch, > HBASE-13153-v6.patch, HBASE-13153-v7.patch, HBASE-13153-v8.patch, > HBASE-13153-v9.patch, HBASE-13153.patch, HBase Bulk Load > Replication-v1-1.pdf, HBase Bulk Load Replication-v2.pdf, HBase Bulk Load > Replication-v3.pdf, HBase Bulk Load Replication.pdf, HDFS_HA_Solution.PNG > > > Currently we plan to use HBase Replication feature to deal with disaster > tolerance scenario.But we encounter an issue that we will use bulkload very > frequently,because bulkload bypass write path, and will not generate WAL, so > the data will not be replicated to backup cluster. It's inappropriate to > bukload twice both on active cluster and backup cluster. So i advise do some > modification to bulkload feature to enable bukload to both active cluster and > backup cluster -- This message was sent by Atlassian JIRA (v6.3.4#6332)