[ https://issues.apache.org/jira/browse/HBASE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020926#comment-15020926 ]
Ashish Singhi commented on HBASE-11393: --------------------------------------- Thanks for the patch. I have given some comments on source code on the RB. Please mark either the comments are fixed or dropped so that it helps next time for the review. > Replication TableCfs should be a PB object rather than a string > --------------------------------------------------------------- > > Key: HBASE-11393 > URL: https://issues.apache.org/jira/browse/HBASE-11393 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Fix For: 2.0.0 > > Attachments: HBASE-11393.patch, HBASE-11393_v1.patch, > HBASE-11393_v10.patch, HBASE-11393_v11.patch, HBASE-11393_v2.patch, > HBASE-11393_v3.patch, HBASE-11393_v4.patch, HBASE-11393_v5.patch, > HBASE-11393_v6.patch, HBASE-11393_v7.patch, HBASE-11393_v8.patch, > HBASE-11393_v9.patch > > > We concatenate the list of tables and column families in format > "table1:cf1,cf2;table2:cfA,cfB" in zookeeper for table-cf to replication peer > mapping. > This results in ugly parsing code. We should do this a PB object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)