[ https://issues.apache.org/jira/browse/HBASE-14895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044451#comment-15044451 ]
Heng Chen commented on HBASE-14895: ----------------------------------- {code} - List<KeyValueScanner> scanners = getScannersNoCompaction(); + final boolean isCompaction = false; + boolean usePread = get || scanUsePread; + List<KeyValueScanner> scanners = store.getScanners(cacheBlocks, get, usePread, isCompaction, + matcher, scan.getStartRow(), scan.getStopRow(), this.readPt); + scanners = updatedStoreFiles(scanners, store.getComparator()); + scanners = selectScannersFrom(scanners); {code} Should we move selectScannersFrom out from getScannersNoCompaction, and we could use getScannersNoCompaction directly here? {code} + protected Set<StoreFileInfo> existingStoreFileInfos = new HashSet<StoreFileInfo>(); {code} What it is used for? It seems there is no use on it? {code} * @param seekKey * @param isLazy true if using lazy seek * @param isParallelSeek true if using parallel seek + * @param updatedStoreFile * @throws IOException */ {code} I did not see param updatedStoreFile in seekScanners..... > Seek only to the newly flushed file on scanner reset on flush > ------------------------------------------------------------- > > Key: HBASE-14895 > URL: https://issues.apache.org/jira/browse/HBASE-14895 > Project: HBase > Issue Type: Sub-task > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-14895.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)