[ https://issues.apache.org/jira/browse/HBASE-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jianwei Cui updated HBASE-14936: -------------------------------- Attachment: HBASE-14936-trunk-v1.patch overwrite getFailedInserts(), getSumHitCountsPastNPeriods(), getSumRequestCountsPastNPeriods(), getSumHitCachingCountsPastNPeriods(), getSumRequestCachingCountsPastNPeriods(), and add test cases. > CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() > ------------------------------------------------------------------ > > Key: HBASE-14936 > URL: https://issues.apache.org/jira/browse/HBASE-14936 > Project: HBase > Issue Type: Bug > Components: BlockCache > Affects Versions: 1.1.2 > Reporter: Jianwei Cui > Attachments: HBASE-14936-trunk-v1.patch, HBASE-14936-trunk.patch > > > It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as > {code} > public void rollMetricsPeriod() { > lruCacheStats.rollMetricsPeriod(); > bucketCacheStats.rollMetricsPeriod(); > } > {code} > otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and > CombinedBlockCache.getHitCachingRatioPastNPeriods() will always return 0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)