[
https://issues.apache.org/jira/browse/HBASE-14534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053082#comment-15053082
]
Nick Dimiduk commented on HBASE-14534:
--------------------------------------
Skimmed patch, LGTM.
bq. Question - how to better test metrics change didn't get changed anywhere
(besides just looking with one's eyes)?
Good question. IIRC, we have nothing like this in place. At best, we would
audit changes to class names and/or constants. Agreed we should make better
guarantees for our operators.
bq. now by default histograms are using exponential decay rather than uniform
sampling, is that ok for us to follow this approach here?
I think that's fine for a major version release. A release note is warranted.
> Bump yammer/coda/dropwizard metrics dependency version
> ------------------------------------------------------
>
> Key: HBASE-14534
> URL: https://issues.apache.org/jira/browse/HBASE-14534
> Project: HBase
> Issue Type: Task
> Reporter: Nick Dimiduk
> Assignee: Mikhail Antonov
> Priority: Minor
> Attachments: HBASE-14534-v2.patch, HBASE-14534.patch, wip.patch
>
>
> After HBASE-12911 lands, let's update our dependency to the latest
> incarnation of this library. I guess they're now calling it Dropwizard
> Metrics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
