[ https://issues.apache.org/jira/browse/HBASE-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142642#comment-13142642 ]
Hudson commented on HBASE-4489: ------------------------------- Integrated in HBase-TRUNK #2402 (See [https://builds.apache.org/job/HBase-TRUNK/2402/]) [jira] [HBASE-4627] Ability to specify a custom start/end to RegionSplitter Summary: [HBASE-4627] added a custom start/end row to RegionSplitter. Also solved an off-by-one error because the end row is prefix-inclusive and not exclusive. <a href="https://issues.apache.org/jira/browse/HBASE-4489" title="Better key splitting in RegionSplitter"><del>HBASE-4489</del></a> changed the default endKey on HexStringSplit from 7FFF... to FFFF... While this is correct, existing users of 0.90 RegionSplitter have 7FFF as the end key in their schema and the last region will not split properly under this new code. We need to let the user specify a custom start/end key range for when situations like this arise. Optimally, we should also write the start/end key in META so we could figure this out implicitly instead of requiring the user to explicitly specify it. Test Plan: - mvn test -Dtest=TestRegionSplitter CC: JIRA Reviewers: DUMMY_REVIEWER Differential Revision: 39 nspiegelberg : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java > Better key splitting in RegionSplitter > -------------------------------------- > > Key: HBASE-4489 > URL: https://issues.apache.org/jira/browse/HBASE-4489 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.90.4 > Reporter: Dave Revell > Assignee: Dave Revell > Fix For: 0.94.0 > > Attachments: HBASE-4489-branch0.90-v1.patch, > HBASE-4489-branch0.90-v2.patch, HBASE-4489-branch0.90-v3.patch, > HBASE-4489-trunk-v1.patch, HBASE-4489-trunk-v2.patch, > HBASE-4489-trunk-v3.patch, HBASE-4489-trunk-v4.patch, > HBASE-4489-trunk-v5.patch > > > The RegionSplitter utility allows users to create a pre-split table from the > command line or do a rolling split on an existing table. It supports > pluggable split algorithms that implement the SplitAlgorithm interface. The > only/default SplitAlgorithm is one that assumes keys fall in the range from > ASCII string "00000000" to ASCII string "7FFFFFFF". This is not a sane > default, and seems useless to most users. Users are likely to be surprised by > the fact that all the region splits occur in in the byte range of ASCII > characters. > A better default split algorithm would be one that evenly divides the space > of all bytes, which is what this patch does. Making a table with five regions > would split at \x33\x33..., \x66\x66...., \x99\x99..., \xCC\xCC..., and > \xFF\xFF. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira