[ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063176#comment-15063176 ]
stack commented on HBASE-14989: ------------------------------- [~enis] bq. I am not sure what is going on. Complaint is this: {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (secondPartTestsExecution) on project hbase-server: There was a timeout or other error in the fork -> [Help 1] {code} ... which is how mvn says a test hung.... didn't complete.... If I run the hang detector, I find the below... which is a hanging test. Needs fix up. Need to integrate this hang check into yetus somehow so don't have to do this external tool run. kalashnikov:hbase.git.commit stack$ python ./dev-support/findHangingTests.py https://builds.apache.org/job/PreCommit-HBASE-Build/16906/consoleText Fetching https://builds.apache.org/job/PreCommit-HBASE-Build/16906/consoleText Building remotely on H6 (Mapreduce Falcon Hadoop Pig Zookeeper Tez Hdfs) in workspace /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build Testing patch for HBASE-14989. Testing patch on branch branch-1. [INFO] Apache HBase ...................................... SUCCESS [2.885s] [INFO] Apache HBase - Checkstyle ......................... SUCCESS [0.570s] [INFO] Apache HBase - Resource Bundle .................... SUCCESS [0.171s] [INFO] Apache HBase - Annotations ........................ SUCCESS [1.031s] [INFO] Apache HBase - Protocol ........................... SUCCESS [12.661s] [INFO] Apache HBase - Common ............................. SUCCESS [1:48.271s] [INFO] Apache HBase - Procedure .......................... SUCCESS [3:30.196s] [INFO] Apache HBase - Client ............................. SUCCESS [1:21.019s] [INFO] Apache HBase - Hadoop Compatibility ............... SUCCESS [7.485s] [INFO] Apache HBase - Hadoop Two Compatibility ........... SUCCESS [8.533s] [INFO] Apache HBase - Prefix Tree ........................ SUCCESS [11.032s] [INFO] Apache HBase - Server ............................. FAILURE [1:41:56.930s] [INFO] Apache HBase - Testing Util ....................... SKIPPED [INFO] Apache HBase - Thrift ............................. SKIPPED [INFO] Apache HBase - Rest ............................... SKIPPED [INFO] Apache HBase - Shell .............................. SKIPPED [INFO] Apache HBase - Integration Tests .................. SKIPPED [INFO] Apache HBase - Examples ........................... SKIPPED [INFO] Apache HBase - External Block Cache ............... SKIPPED [INFO] Apache HBase - Assembly ........................... SKIPPED [INFO] Apache HBase - Shaded ............................. SKIPPED [INFO] Apache HBase - Shaded - Client .................... SKIPPED [INFO] Apache HBase - Shaded - Server .................... SKIPPED Printing hanging tests Hanging test : org.apache.hadoop.hbase.master.TestSplitLogManager > Implementation of Mutation.getWriteToWAL() is backwards > ------------------------------------------------------- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug > Reporter: James Taylor > Assignee: Enis Soztutar > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.1.branch-1.patch, > hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should > return true if this.durability == Durability.SYNC_WAL: > {code} > /** > * @deprecated Use {@link #getDurability()} instead. > * @return true if edits should be applied to WAL, false if not > */ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following > code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it > will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)