[ 
https://issues.apache.org/jira/browse/HBASE-15035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070587#comment-15070587
 ] 

ramkrishna.s.vasudevan commented on HBASE-15035:
------------------------------------------------

[~jmhsieh]
Good find. 
One suggestion
Instead of directly setting includeTags as true in LoadIncrementalHFiles - can 
we see if
{code}
halfReader.getHFileReader().getFileContext().isIncludesTags()
{code}
And if that halfReader has tags then include the tags in the new Writer also? 
Though not a problem - you can add a coprocessor and check for the presence of 
tags on the server side itself after Incremental load instead of changing the 
Rpc Codec. But that is also fine. 

> bulkloading hfiles with tags that require splits do not preserve tags
> ---------------------------------------------------------------------
>
>                 Key: HBASE-15035
>                 URL: https://issues.apache.org/jira/browse/HBASE-15035
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 0.98.0, 1.0.0, 2.0.0, 1.1.0, 1.2.0, 1.3.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>            Priority: Blocker
>         Attachments: HBASE-15035-v2.patch, HBASE-15035.patch
>
>
> When an hfile is created with cell tags present and it is bulk loaded into 
> hbase the tags will be present when loaded into a single region.  If the bulk 
> load hfile spans multiple regions, bulk load automatically splits the 
> original hfile into a set of split hfiles corresponding to each of the 
> regions that the original covers.  
> Since 0.98, tags are not copied into the newly created split hfiles. (the 
> default for "includeTags" of the HFileContextBuilder [1] is uninitialized 
> which defaults to false).   This means acls, ttls, mob pointers and other tag 
> stored values will not be bulk loaded in.
> [1]  
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContextBuilder.java#L40



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to