[
https://issues.apache.org/jira/browse/HBASE-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086408#comment-15086408
]
Jonathan Hsieh commented on HBASE-15069:
----------------------------------------
Hadoop's FileSystem.get(..) eventually calls this [1] which gets a cached
version. So we may be creating a few extra HFileSystem wrappers around the
same FileSystem instances
[1]
https://github.com/apache/hadoop-common/blob/HADOOP-3628/src/core/org/apache/hadoop/fs/FileSystem.java#L185
> Unify HFile Writer and Reader creation patterns
> -----------------------------------------------
>
> Key: HBASE-15069
> URL: https://issues.apache.org/jira/browse/HBASE-15069
> Project: HBase
> Issue Type: Bug
> Components: HFile
> Affects Versions: 2.0.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 2.0.0
>
> Attachments: hbase-15069.patch, hbase-15069.v2.patch,
> hbase-15069.v3.patch
>
>
> There are a plethora of different static methods sprinkled through out
> HStoreFile and HFile, and many tests that have extraneous calls to 'new
> CacheConfig(conf)' or essentially extraneous FileSystem arguments threaded
> through out the code.
> This patch forces all creation to go through HFile Reader and Writer
> Builders, eliminates all static Builder constructors, and limits the exposure
> Reader/Writers . It also forces all HFile writer uses outside of the
> o.a.h.h.io.hfile package to use the StoreFile writers
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)