[ https://issues.apache.org/jira/browse/HBASE-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086439#comment-15086439 ]
Matteo Bertozzi edited comment on HBASE-15069 at 1/6/16 10:54 PM: ------------------------------------------------------------------ can we at least avoid the direct FileSystem.get() and use something that we can control a bit more? like FSUtils.getCurrentFileSystem(conf) how can I mock a fs or force to use what I want everywhere after this change? was (Author: mbertozzi): can we at least avoid the direct FileSystem.get() and use something that we can control a bit more? like FSUtils.getCurrentFileSystem(conf) > Unify HFile Writer and Reader creation patterns > ----------------------------------------------- > > Key: HBASE-15069 > URL: https://issues.apache.org/jira/browse/HBASE-15069 > Project: HBase > Issue Type: Bug > Components: HFile > Affects Versions: 2.0.0 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-15069.patch, hbase-15069.v2.patch, > hbase-15069.v3.patch > > > There are a plethora of different static methods sprinkled through out > HStoreFile and HFile, and many tests that have extraneous calls to 'new > CacheConfig(conf)' or essentially extraneous FileSystem arguments threaded > through out the code. > This patch forces all creation to go through HFile Reader and Writer > Builders, eliminates all static Builder constructors, and limits the exposure > Reader/Writers . It also forces all HFile writer uses outside of the > o.a.h.h.io.hfile package to use the StoreFile writers -- This message was sent by Atlassian JIRA (v6.3.4#6332)