[ https://issues.apache.org/jira/browse/HBASE-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143990#comment-13143990 ]
gaojinchao commented on HBASE-4749: ----------------------------------- It seems a bug for TRUNK. In version 0.90, We kill a RS and at same time start a Master, Master don't add a dying RS to online set. But in version 0.92 We will add a dying RS to online set. This will produce a lot of unusual scenarios: 1. if the root/meta is in a dying RS, we may lose data because don't split Hlog. looks issue: https://issues.apache.org/jira/browse/HBASE-4511. 2.In testMasterFailoverWithMockedRITOnDeadRScase , mocking scenarios will be invalid. look this logs: //we kill this RS(1320357166142 ) 2011-11-03 21:52:56,007 INFO [Thread-986] master.TestMasterFailover(1011): Killing RS juno.apache.org,60001,1320357166142 //we pick up this RS(1320357166142) through zk node. 2011-11-03 21:52:57,356 INFO [Master:0;juno.apache.org,51313,1320357176029] master.HMaster(464): Registering server found up in zk: juno.apache.org,60001,1320357166142 2011-11-03 21:52:57,357 INFO [Master:0;juno.apache.org,51313,1320357176029] master.ServerManager(239): Registering server=juno.apache.org,60001,1320357166142 So I think we should wait until killing RS is shut down and start a new hmaster. > TestMasterFailover case occasional fails > ---------------------------------------- > > Key: HBASE-4749 > URL: https://issues.apache.org/jira/browse/HBASE-4749 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.92.0 > Reporter: gaojinchao > Priority: Minor > Fix For: 0.92.0 > > > look this logs: > https://builds.apache.org/view/G-L/view/HBase/job/HBase-0.92/105/testReport/org.apache.hadoop.hbase.master/TestMasterFailover/testMasterFailoverWithMockedRITOnDeadRS/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira