[ https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144316#comment-13144316 ]
Phabricator commented on HBASE-4742: ------------------------------------ khemani has commented on the revision "[jira] [HBASE-4742] Split dead server's log in parallel". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:316 name the thread for better jstacks src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:311 I don't think there is a need for ABORT state. There is no aborting the log-splitting ... we should just keep retrying. In this particular case when deadServer doesn't exist then you can return success src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:295 You could put the retry loop with sleeps here? Then the main thread has a very simple state where it just requeues itself if the log-splitting is not done. REVISION DETAIL https://reviews.facebook.net/D237 > Split dead server's log in parallel > ----------------------------------- > > Key: HBASE-4742 > URL: https://issues.apache.org/jira/browse/HBASE-4742 > Project: HBase > Issue Type: Improvement > Reporter: Liyin Tang > Assignee: Liyin Tang > Attachments: D237.1.patch > > > When one region server goes down, the master will shutdown the region server > and split its log. > However, splitting log is a blocking call and it would take some time. > If more than one region server go down, the master will split its log one by > one, which is not efficient. > Since we have the distributed log split, we could split these logs from the > dead servers in parallel. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira