[
https://issues.apache.org/jira/browse/HBASE-4740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144376#comment-13144376
]
stack commented on HBASE-4740:
------------------------------
Is this right Jon, setting maxRetries to 0 by default?
{code}
+ int maxRetries = cfg.getInt("hbase.bulkload.retries.number", 0);
{code}
This is a little odd looking but thats it (could let auto-boxing take care of
the boolean to Boolean):
{code}
+ public Boolean call() throws Exception {
{code}
This code looks a lot like whats in the populateTable method:
{code}
// create HFiles for different column families
- Path bulk2 = new Path(dir, "bulkload2");
- buildHFiles(fs, bulk2, 2); // all values are '2'
- lih2.doBulkLoad(bulk2, t);
+ Path dir = util.getDataTestDir(table);
+ FileSystem fs = util.getTestFileSystem();
+ Path bulk = new Path(dir, "bulkload2");
+ HTable t = new HTable(util.getConfiguration(), Bytes.toBytes(table));
+ buildHFiles(fs, bulk, 2); // all values are '2'
+ lih2.doBulkLoad(bulk, t);
{code}
Code dup?
Patch seems fine. Did you try it on a cluster Jon?
> [bulk load] the HBASE-4552 API can't tell if errors on region server is
> recoverable or unrecoverable error.
> ------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4740
> URL: https://issues.apache.org/jira/browse/HBASE-4740
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments:
> 0001-HBASE-4740-bulkload-HBASE-4552-API-can-t-tell-if-err.patch
>
>
> Running TestHFileOutputFormat more frequently seems to show that it has
> become flaky. It is difficult to tell if this is because of a unrecoverable
> failure or a recoverable failure. To make this visiable from test and for
> users, we need to make a change to bulkload call's interface on
> HRegionServer. The change should make successful rpcs return true,
> recoverable failures return false, and unrecoverable failure throw an
> IOException. This is an RPC change, so it would be really good to get this
> api right before the final 0.92 goes out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
