[ 
https://issues.apache.org/jira/browse/HBASE-14167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098326#comment-15098326
 ] 

Sean Busbey commented on HBASE-14167:
-------------------------------------

{code}
+      <activation>
+        <property>
+          <name>skipIntegrationTests</name>
+        </property>
+      </activation>
{code}

[~apurtell], are we using "skipIntegrationTests" so that we purposefully don't 
match the failsafe plugin's use of "skipITs" ? It'll mean that to run verify 
without any integration tests we'll need to do {{mvn -DskipITs 
-DskipIntegrationTests verify}}, which seems awkward.

Related, our current nightly builds rely on the {{it.test}} property to skip 
running integration tests on our unit test builds, and to choose the 
integration test to run in our matrix IT runs. right now, I believe the spark 
module runs all of its ITs on all of these runs, because it also doesn't 
respect that property the way the failsafe plugin does.

{code}
+        <surefire.skipFirstPart>true</surefire.skipFirstPart>
+        <surefire.skipSecondPart>true</surefire.skipSecondPart>
{code}

This shouldn't be done since it will cause us to skip unit tests when we asked 
to skip integration tests. (TestJavaHBaseContext should still run when we ask 
to skip integration tests is active)

{code}
+      <properties>
+        <skipTests>true</skipTests>
{code}

This has the same problem of also skipping our unit tests. I think you'll need 
to set this configuration on the scalatest-maven-plugin 
([ref|http://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin]), 
specifically on the integration-test execution (similar to how we configure the 
default execution to skip non-integration scala tests).

> hbase-spark integration tests do not respect -DskipIntegrationTests
> -------------------------------------------------------------------
>
>                 Key: HBASE-14167
>                 URL: https://issues.apache.org/jira/browse/HBASE-14167
>             Project: HBase
>          Issue Type: Improvement
>          Components: pom, spark
>    Affects Versions: 2.0.0
>            Reporter: Andrew Purtell
>            Assignee: Gabor Liptak
>            Priority: Minor
>         Attachments: HBASE-14167-master-v2.patch, HBASE-14167.11.patch
>
>
> When running a build with {{mvn ... -DskipIntegrationTests}}, the hbase-spark 
> module's integration tests do not respect the flag and run anyway. Fix. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to