[ 
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103724#comment-15103724
 ] 

Duo Zhang commented on HBASE-14969:
-----------------------------------

{quote}
My only concern is that this will require user to modify their configuration if 
use PressureAwareCompressionThroughputController.
{quote}
Yes this is a problem. I think we could map 
{{org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompressionThroughputController}}
 to 
{{org.apache.hadoop.hbase.regionserver.throttle.PressureAwareCompressionThroughputController}}
 in {{CompactionThroughputControllerFactory}}. And also for 
{{NoLimitCompactionThroughputController}}.

{quote}
Is it possible we add any separate logic in setup/start/finish method for flush 
and compaction no-limit-controller in the future?
{quote}
I think 'no limit' itself does not have other meanings. People could introduce 
other {{ThroughputController}} if they want(just use a different name).

And I left some comments on rb, only small changes.

Thanks.

> Add throughput controller for flush
> -----------------------------------
>
>                 Key: HBASE-14969
>                 URL: https://issues.apache.org/jira/browse/HBASE-14969
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-14969.patch, HBASE-14969_v2.patch, 
> HBASE-14969_v3.patch, HBASE-14969_v4.patch, HBASE-14969_v5.patch, 
> HBASE-14969_v6.patch, load-nothrottling.log, load-throttling.log
>
>
> In HBASE-8329 we added a throughput controller for compaction, to avoid spike 
> caused by huge IO pressure like network/disk overflow. However, even with 
> this control on, we are still observing disk utils near 100%, and by analysis 
> we think this is caused by flush, especially when we increase the setting of 
> {{hbase.hstore.flusher.count}}
> In this JIRA, we propose to add throughput control feature for flush, as a 
> supplement of HBASE-8329 to better control IO pressure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to