[ https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144917#comment-13144917 ]
Phabricator commented on HBASE-4742: ------------------------------------ Liyin has commented on the revision "[jira] [HBASE-4742] Split dead server's log in parallel". Mikhail, since the function to split log is a blocking function. So it will return unit the splitLogManager says all the logs has been spitted successfully. Anyway, I implemented the ThreadPool version, which is much easy to change. I will keep test it in the dev cluster and discuss with Prakash about the above concern. In addition, in apache trunk, it handle these region server shut down cases in parallel. So by design, the function to distributed log splitting is supposed to be run in parallel. Let's get it confirmed by Prakash and testing. Thank all of you guys for reviewing it in the weekend:) Liyin REVISION DETAIL https://reviews.facebook.net/D237 > Split dead server's log in parallel > ----------------------------------- > > Key: HBASE-4742 > URL: https://issues.apache.org/jira/browse/HBASE-4742 > Project: HBase > Issue Type: Improvement > Reporter: Liyin Tang > Assignee: Liyin Tang > Attachments: D237.1.patch, D237.2.patch, D237.3.patch, D237.4.patch, > D237.5.patch > > > When one region server goes down, the master will shutdown the region server > and split its log. > However, splitting log is a blocking call and it would take some time. > If more than one region server go down, the master will split its log one by > one, which is not efficient. > Since we have the distributed log split, we could split these logs from the > dead servers in parallel. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira