[
https://issues.apache.org/jira/browse/HBASE-14841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114967#comment-15114967
]
ramkrishna.s.vasudevan commented on HBASE-14841:
------------------------------------------------
bq.This needs a copy. Any way no one calls this and it is not expected. So
better can throw Exception here.
bq. Same way as in another class with setContent(byte[])
I wanted to do that but decided not to do that even in case if some one uses
that accidentally. I think it is fine not to throw Exception here.
bq.why equals not checking instance of other type? May be in actual flow it is
coming out to be this way. But better handle fully. Else code looks to have
bug. Pls handle.
Here again you want to check both types? I was particularly not sure if we
want to do that - let me try that. Currently there is no BytebufferNode stored
in the dictionary it is only going to be a holder.
{code}
compressTags(out, in.array(), offset + in.position(), length);
{code}
this is good catch. When offset is there we can just use that directly.
> Allow Dictionary to work with BytebufferedCells
> -----------------------------------------------
>
> Key: HBASE-14841
> URL: https://issues.apache.org/jira/browse/HBASE-14841
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-14841.patch, HBASE-14841_1.patch,
> HBASE-14841_2.patch, HBASE-14841_3.patch, HBASE-14841_4.patch
>
>
> This is part of HBASE-14832 where we need to ensure that while BBCells are
> getting compacted the TagCompression part should be working with BBCells.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
