[ 
https://issues.apache.org/jira/browse/HBASE-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145627#comment-13145627
 ] 

Phabricator commented on HBASE-4627:
------------------------------------

nspiegelberg has commented on the revision "[jira] [HBASE-4627] Ability to 
specify a custom start/end to RegionSplitter".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/util/Bytes.java:1417 sorry, the 
iterator uses intervalBI, not diffBI

    for i in range(splitsBI):
       yield startBI + i * intervalBI

  logic is still the same.

REVISION DETAIL
  https://reviews.facebook.net/D39

COMMITS
  https://reviews.facebook.net/rHBASE1196256
  https://reviews.facebook.net/rHBASE1196772

                
> Ability to specify a custom start/end to RegionSplitter
> -------------------------------------------------------
>
>                 Key: HBASE-4627
>                 URL: https://issues.apache.org/jira/browse/HBASE-4627
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.0
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>         Attachments: D39.1.patch, D39.1.patch, D39.1.patch
>
>
> HBASE-4489 changed the default endKey on HexStringSplit from 7FFF... to 
> FFFF...  While this is correct, existing users of 0.90 RegionSplitter have 
> 7FFF as the end key in their schema and the last region will not split 
> properly under this new code.  We need to let the user specify a custom 
> start/end key range for when situations like this arise.  Optimally, we 
> should also write the start/end key in META so we could figure this out 
> implicitly instead of requiring the user to explicitly specify it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to