[
https://issues.apache.org/jira/browse/HBASE-15204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140304#comment-15140304
]
ramkrishna.s.vasudevan commented on HBASE-15204:
------------------------------------------------
I think the report was clean this time.
bq.Patch generated 1 new checkstyle issues in hbase-server (total was 216, now
216).
No checkstyle added newly.
bq../hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:2940:3:
error: Method length is 310 lines (max allowed is 150).
This was not added by this patch. So will not change it here because it needs
proper refactoring. Ping for reviews [[email protected]].
> Try to estimate the cell count for adding into WALEdit
> ------------------------------------------------------
>
> Key: HBASE-15204
> URL: https://issues.apache.org/jira/browse/HBASE-15204
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15204.patch, HBASE-15204_1.patch,
> HBASE-15204_1.patch, HBASE-15204_2.patch, HBASE-15204_3.patch,
> HBASE-15204_3.patch, HBASE-15204_4.patch, WAlEdit_add_allocation.jpg,
> WAlEdit_add_allocation_after_patch.jpg
>
>
> The write path profiling shows that when we try to add Cells to WALEdits we
> try to do a lot of Array copy inorder to grow the Arraylist backing the
> WALEdits. In a simple one min profiling of the write path with 50 YCSB
> threads shows around 261MB of allocation done for the Array copy to happen.
> We can try to avoid that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
