[
https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146638#comment-13146638
]
Phabricator commented on HBASE-4742:
------------------------------------
Kannan has commented on the revision "[jira] [HBASE-4742] Split dead server's
log in parallel".
Nice work Liyin. One inlined comment.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:323
there are two queues, the toDoQueue and the delayedToDoQueue.
From reading the code, it seems like "return false" will cause this to be put
in the toDoQueue upstream in RegionServerOperationQueue.java.
Should we instead use "this.requeue()" so that it is back in the delay queue,
but then, return *true*, so that it doesn't *also* get put in the toDoQueue?
REVISION DETAIL
https://reviews.facebook.net/D237
> Split dead server's log in parallel
> -----------------------------------
>
> Key: HBASE-4742
> URL: https://issues.apache.org/jira/browse/HBASE-4742
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D237.1.patch, D237.2.patch, D237.3.patch, D237.4.patch,
> D237.5.patch, D237.6.patch, D237.7.patch, D237.8.patch
>
>
> When one region server goes down, the master will shutdown the region server
> and split its log.
> However, splitting log is a blocking call and it would take some time.
> If more than one region server go down, the master will split its log one by
> one, which is not efficient.
> Since we have the distributed log split, we could split these logs from the
> dead servers in parallel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
